Fix some message formatting failures, improve test coverage #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in broken matrix formatting. Tests are now also updated, in line with existing and expected behaviour. Signed-off-by: Tadeusz „tadzik” Sośnierz <[email protected]>
…ly fallbacks Fixes matrix-orgGH-737 Signed-off-by: Tadeusz „tadzik” Sośnierz <[email protected]>
This was referenced Apr 4, 2024
Half-Shot
approved these changes
Apr 5, 2024
Contributor
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
Just needs a newsfile.
auscompgeek
reviewed
Apr 6, 2024
Co-authored-by: David Vo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix at least some cases of #737 – at least the ones I could reproduce.